Skip to content

fix(menu): ignore Ctrl+K on macOS - #131

Merged
unvalley merged 2 commits into
unvalley:mainfrom
yukukotani:fix/macos-command-k
Nov 14, 2026
Merged

unvalley merged 2 commits into
unvalley:mainfrom
yukukotani:fix/macos-command-k

Conversation

@yukukotani

Copy link
Copy Markdown
Contributor

Why

Ctrl+K opens the command menu on macOS and conflicts with Japanese katakana conversion. Use Command on macOS and Control on Windows and Linux.

What changed

  • Use the existing platform check in both the open and close keyboard handlers.
  • Add browser regression tests for macOS, Windows, and Linux, including Ctrl+K while the macOS menu is open.
  • Select shortcut keys from the browser platform rather than the test runner's host platform in existing menu tests.

Scope

  • Cover command menu keyboard behavior without changing Escape or click behavior.
  • Leave unrelated editor shortcuts, menu labels, and existing tooltip and Picture-in-Picture test failures unchanged.

Blast Radius

This changes the modifier accepted by the command menu. macOS uses Command+K, while Windows and Linux keep Ctrl+K.

Verification

  • pnpm exec playwright test e2e/command-menu-shortcuts.spec.ts --reporter=line failed on macOS Ctrl+K before the fix and passed all 3 cases after it.
  • pnpm test:unit --run, pnpm exec tsc --noEmit, and Biome lint passed. The unit suite contains 157 tests.
  • pnpm exec playwright test --reporter=line finished with 10 passing tests and 3 failures. The same tooltip failures and Picture-in-Picture navigation failure reproduced with the original production code.

@unvalley

Copy link
Copy Markdown
Owner

@yukukotani oops sorry i didn't notice! thank you!

@unvalley
unvalley merged commit b383964 into unvalley:main Nov 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants