Repository navigation
fix(menu): ignore Ctrl+K on macOS - #131
Merged
Merged
Conversation
Owner
|
@yukukotani oops sorry i didn't notice! thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Ctrl+K opens the command menu on macOS and conflicts with Japanese katakana conversion. Use Command on macOS and Control on Windows and Linux.
What changed
Scope
Blast Radius
This changes the modifier accepted by the command menu. macOS uses Command+K, while Windows and Linux keep Ctrl+K.
Verification
pnpm exec playwright test e2e/command-menu-shortcuts.spec.ts --reporter=linefailed on macOS Ctrl+K before the fix and passed all 3 cases after it.pnpm test:unit --run,pnpm exec tsc --noEmit, and Biome lint passed. The unit suite contains 157 tests.pnpm exec playwright test --reporter=linefinished with 10 passing tests and 3 failures. The same tooltip failures and Picture-in-Picture navigation failure reproduced with the original production code.